boards: posix: native_posix: enable can_loopback0 by default #50530
Conversation
martinjaeger
requested review from
aescolar,
alexanderwachter,
daor-oti,
henrikbrixandersen,
pfalcon,
rlubos and
tbursztyka
as code owners
zephyrbot
added
area: Networking
area: Sockets
henrikbrixandersen
left a comment
henrikbrixandersen
left a comment
There was a problem hiding this comment.
Thanks. I left it as disabled since the loopback driver was not sufficient to run all the test suites back then. Should be fine now, though.
Ok, I see. Now we get several failing tests which were previously just not run. The counter sample should be excluded from the tests because it keeps running for ever and thus times out, but the ISO-TP failures may be actual issues with the loopback driver or ISO-TP itself. I'd suggest to exclude the native_posix board from the ISO-TP tests for now. |
martinjaeger
dismissed stale reviews from jukkar and henrikbrixandersen
via
cbab91a
martinjaeger
force-pushed
the
native-posix-can-loopback-default
branch
from
fde03cd to
cbab91a
Compare
The .yaml file states that CAN is supported, but the basic sample application samples/drivers/can/counter cannot be compiled without additional configuration. The loopback driver does not require any additional steps like the linux SocketCAN driver, so it is safe to enable it by default and get rid of the many overlay files in the tests. ISO-TP tests and the counter sample are excluded via .yaml from twister tests because of timing issues. Signed-off-by: Martin Jäger <[email protected]>
martinjaeger
force-pushed
the
native-posix-can-loopback-default
branch
from
cbab91a to
3a280ba
Compare
|
For some reason |
|
We really need to look into the ISO-TP protocol implementation post v3.2. The tests are failing on multiple boards. Either the implementation is flawed or the tests are. |
|
I have removed the "bug" label as I do not see this as a bug. We have filtering in place ( |
|
Hey, tagged for v3.3.0, feel free to update if you think this should be considered a bugfix. |
7 participants
The .yaml file states that CAN is supported and
zephyr,canbusis chosen in the dts, but building the basic sample application samples/drivers/can/counter fails without additional configuration.The loopback driver does not require any additional steps like the linux SocketCAN driver, so it is safe to enable it by default and get rid of the many overlay files in the tests.